quoted

quoted

On Tue, Jul 8, 2008 at  1:00 AM, in message

[ref], Nick Piggin
[off-list ref] wrote: 

On Saturday 28 June 2008 06:29, Gregory Haskins wrote:

quoted

Inspired by Peter Zijlstra.

Signed-off-by: Gregory Haskins <redacted>

What happened to the feedback I sent about this?

It is still nack from me.

Ah yes.  Slipped through the cracks...sorry about that.

What if we did "if (idle == CPU_NEWLY_IDLE && need_resched())" instead?

-Greg

quoted

---

 kernel/sched.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 56722b1..0b9f90e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c

@@ -2863,6 +2863,10 @@ static int move_tasks(struct rq *this_rq, int

this_cpu, struct rq *busiest, max_load_move - total_load_moved,
 				sd, idle, all_pinned, &this_best_prio);
 		class = class->next;
+
+		if (idle == CPU_NEWLY_IDLE && this_rq->nr_running)
+			break;
+
 	} while (class && max_load_move > total_load_moved);

 	return total_load_moved > 0;

--