Re: [PATCH 2/3] sched: terminate newidle balancing once at least one task has moved over
From: Nick Piggin <hidden>
Date: 2008-07-08 05:00:50
Also in:
lkml
From: Nick Piggin <hidden>
Date: 2008-07-08 05:00:50
Also in:
lkml
On Saturday 28 June 2008 06:29, Gregory Haskins wrote:
Inspired by Peter Zijlstra. Signed-off-by: Gregory Haskins <redacted>
What happened to the feedback I sent about this? It is still nack from me.
--- kernel/sched.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)diff --git a/kernel/sched.c b/kernel/sched.c index 56722b1..0b9f90e 100644 --- a/kernel/sched.c +++ b/kernel/sched.c@@ -2863,6 +2863,10 @@ static int move_tasks(struct rq *this_rq, intthis_cpu, struct rq *busiest, max_load_move - total_load_moved, sd, idle, all_pinned, &this_best_prio); class = class->next; + + if (idle == CPU_NEWLY_IDLE && this_rq->nr_running) + break; + } while (class && max_load_move > total_load_moved); return total_load_moved > 0; --