Re: [PATCH] release quicklist before free_page
From: Ingo Molnar <hidden>
Date: 2007-07-23 18:23:41
Also in:
lkml
From: Ingo Molnar <hidden>
Date: 2007-07-23 18:23:41
Also in:
lkml
* Daniel Walker [off-list ref] wrote:
quoted
Not quite, it uses preempt_disable() to avoid migration and stick to a cpu. Without that it might end up freeing pages from another quicklist.
i.e. the patch hides a debug warning and there's possibly silent data corruption - not good.
quoted
How about this - compile tested onlyHow about a comment to go with it ? Which says something like what's above, notes on how the locking is getting used..
how about: "if you've got some time then please also add a few comments, because the code was quite non-obvious to me and I misunderstood it when I tried to fix it. Thanks." ok? Ingo