On Wed, Sep 01, 2021 at 11:43:34AM +0000, Chesnokov Gleb wrote:

b) listener cm_id does not need to be recreated,
that is, RDMA_CM_EVENT_ADDR_CHANGE is informative for it.

I depends on what is in sa = (struct sockaddr *)&np->np_sockaddr;

If that is not a wildcard then the listen is only good so long as that
address the one assigned to the interface.

I'm not sure why isert would use a non-wildcard listen?

In any event if the isert_setup_np() was called with a specific
address:

static int
isert_setup_np(struct iscsi_np *np,
	       struct sockaddr_storage *ksockaddr)

Then the np should operate on that address, and only that address, and
not quitely change to some other address during operation. So again I
think the original proposal is not right - though I don't know enough
about iscsi insides to suggest what is wrong here.

Jason