Re: [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-07-22 14:23:51
On Mon, Jul 19, 2021 at 11:29:40AM -0700, Sagi Grimberg wrote:
quoted
quoted
What is this trying to do anyhow? If the addr has truely changed why does the bind fail?When the active physical link member of bonding interface in active-standby mode gets faulty, the standby link will represent the assigned addresses on behalf of the active link. Therefore, RDMA communication manager will notify iSER target with RDMA_CM_EVENT_ADDR_CHANGE.Ah, here is my recollection... However I think that if we move that into a work, we should do it periodically until we succeed or until the endpoint is torn down so we can handle address removed and restore use-cases.
That soudns better, but still I would say this shouldn't even happen in the first place, check the address and don't initiate rebinding if it hasn't changed. Jason