Thread (20 messages) 20 messages, 3 authors, 2021-07-21

Re: [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations interface for uverbs

From: Leon Romanovsky <leon@kernel.org>
Date: 2021-07-21 07:31:47
Also in: lkml

On Wed, Jul 21, 2021 at 08:12:35AM +0100, Christoph Hellwig wrote:
On Wed, Jul 21, 2021 at 10:06:06AM +0300, Leon Romanovsky wrote:
quoted
You will need to add some sort of "if qp tpye" for ib_create_qp_uverbs() callers,
because they always provide udata != NULL. 

After this series, the callers look like this:

 1438         qp = ib_create_qp_uverbs(device, pd, &attr, &attrs->driver_udata, obj);
                                                          ^^^^^^^^^ not NULL

So instead of bothering callers, I implemented it here with one "if".
Sorry if my mail was confusing.  I don't want it in the callers, I
want it as deep down in the stack as possible instead of having the
strange wrapper.
I see, will change and resend.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help