Thread (20 messages) 20 messages, 3 authors, 2021-07-21

Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-07-21 06:48:13
Also in: lkml

+/**
+ * ib_create_qp_kernel - Creates a kernel QP associated with the specified
Any reason this function is renamed?  This seems rather unrelated to
the rest of th patch.
+ *   protection domain.
  * @pd: The protection domain associated with the QP.
  * @qp_init_attr: A list of initial attributes required to create the
  *   QP.  If QP creation succeeds, then the attributes are updated to
  *   the actual capabilities of the created QP.
  * @caller: caller's build-time module name
- *
- * NOTE: for user qp use ib_create_qp_user with valid udata!
  */
Also a kerneldoc comment for a function that is an implementation
detail is actively harmful.  Please document ib_create_qp instead.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help