Thread (42 messages) 42 messages, 7 authors, 2023-06-16

Re: [PATCH 02/11] md-bitmap: initialize variables at declaration time in md_bitmap_file_unmap

From: Himanshu Madhani <hidden>
Date: 2023-06-15 17:06:09
Also in: linux-block, linux-fsdevel

quoted hunk ↗ jump to hunk
On Jun 14, 2023, at 11:48 PM, Christoph Hellwig [off-list ref] wrote:

Just a small tidyup to prepare for bigger changes.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/md/md-bitmap.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index d8469720fac23f..0b2d8933cbc75e 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -842,14 +842,10 @@ static int md_bitmap_storage_alloc(struct bitmap_storage *store,
static void md_bitmap_file_unmap(struct bitmap_storage *store)
{
- struct page **map, *sb_page;
- int pages;
- struct file *file;
-
- file = store->file;
- map = store->filemap;
- pages = store->file_pages;
- sb_page = store->sb_page;
+ struct file *file = store->file;
+ struct page *sb_page = store->sb_page;
+ struct page **map = store->filemap;
+ int pages = store->file_pages;

while (pages--)
if (map[pages] != sb_page) /* 0 is sb_page, release it below */
-- 
2.39.2
Reviewed-by: Himanshu Madhani <redacted>

-- 
Himanshu Madhani Oracle Linux Engineering
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help