Re: [PATCH v6 16/20] dm-crypt: check if adding pages to clone bio fails

On 30.05.23 18:10, Mike Snitzer wrote:

On Tue, May 30 2023 at 11:49P -0400,
Johannes Thumshirn [off-list ref] wrote:

quoted

Check if adding pages to clone bio fails and if it does retry with
reclaim. This mirrors the behaviour of page allocation in
crypt_alloc_buffer().

Nope.

quoted

This way we can mark bio_add_pages as __must_check.

Reviewed-by: Damien Le Moal <redacted>
Signed-off-by: Johannes Thumshirn <redacted>

The above patch header doesn't reflect the code.

I also think __bio_add_page should be used, like my racey reply to
Mikulas vs your v6 patchbomb said, please see:
https://listman.redhat.com/archives/dm-devel/2023-May/054388.html

Yep that mail was racing with my send of v6.

I can send out a v7 of the series tomorrow or just that one patch updated.
Whatever Jens preferes.