Thread (25 messages) 25 messages, 4 authors, 2022-01-26

Re: [PATCH 1/3] raid0, linear, md: add error_handlers for raid0 and linear

From: Guoqing Jiang <hidden>
Date: 2021-12-17 02:07:51


On 12/17/21 10:00 AM, Guoqing Jiang wrote:
quoted
+static inline bool is_rdev_broken(struct md_rdev *rdev)
  {
-    if (!disk_live(rdev->bdev->bd_disk)) {
-        if (!test_and_set_bit(MD_BROKEN, &rdev->mddev->flags))
-            pr_warn("md: %s: %s array has a missing/failed member\n",
-                mdname(rdev->mddev), md_type);
-        return true;
-    }
-    return false;
+    return !disk_live(rdev->bdev->bd_disk);
  }

Besides, if MD_BROKEN is not set here then I think you can also delete the
flag from other places as well.
Oops, I didn't notice the flag is set elsewhere.

Thanks,
Guoqing
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help