Re: [PATCH V2 0/7] md: io stats accounting
From: Paweł Wiejacha <hidden>
Date: 2021-05-27 14:10:10
On Mon, 24 May 2021 at 08:04, Song Liu [off-list ref] wrote:
On Thu, May 20, 2021 at 5:56 PM Guoqing Jiang [off-list ref] wrote:quoted
V2 changes: 1. add accounting_bio to md_personality. 2. cleanup in case bioset_integrity_create fails. 3. use bio_end_io_acct. 4. remove patch for enable io accounting for multipath. 5. add one patch to rename print_msg. 6. add one patch to deprecate linear, multipath and faulty. Artur Paszkiewicz (1): md: the latest try for improve io stats accounting Guoqing Jiang (6): md: revert io stats accounting md: add accounting_bio for raid0 and raid5 md/raid1: rename print_msg with r1bio_existed md/raid1: enable io accounting md/raid10: enable io accounting md: mark some personalities as deprecatedThanks Guoqing! This version looks great to me. No need to send v3 for those two minor comments. Artur and Christoph, could you please share your comments on this version and/or reply with your Reviewed-by tag? Pawel, could you please run your tests with this set? Note that, the test should be run after setting echo 1 > /sys/block/mdXXX/queue/iostats
I've been testing this patchset for a while (with md iostats enabled) and no double fault occurred. Thanks! Paweł Wiejacha
Thanks, Songquoted