Thread (16 messages) 16 messages, 5 authors, 2021-05-27

Re: [PATCH V2 3/7] md: the latest try for improve io stats accounting

From: Artur Paszkiewicz <hidden>
Date: 2021-05-21 07:33:03

quoted hunk ↗ jump to hunk
@@ -2340,9 +2383,12 @@ int md_integrity_register(struct mddev *mddev)
                             bdev_get_integrity(reference->bdev));
 
      pr_debug("md: data integrity enabled on %s\n", mdname(mddev));
-     if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE)) {
+     if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE) ||
+         bioset_integrity_create(&mddev->md_io_bs, BIO_POOL_SIZE)) {
              pr_err("md: failed to create integrity pool for %s\n",
                     mdname(mddev));
+             bioset_exit(&mddev->bio_set);
+             bioset_exit(&mddev->md_io_bs);
              return -EINVAL;
Are you sure bioset_exit() here is correct? This is always called from
pers->run() and the cleanup in case of error is handled in md_run().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help