Re: [PATCH 04/12] bdi: initialize ->ra_pages and ->io_pages in bdi_init

From
Jan Kara <jack@suse.cz>
Date
2020-09-17 10:05:08
Also in
cgroups, dm-devel, linux-block, linux-fsdevel, linux-mm, lkml
Reply to
Christoph Hellwig, 2020-09-10
On Thu 10-09-20 16:48:24, Christoph Hellwig wrote:
Set up a readahead size by default, as very few users have a good
reason to change it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David Sterba <dsterba@suse.com> [btrfs]
Acked-by: Richard Weinberger <richard@nod.at> [ubifs, mtd]
Looks good but what about coda, ecryptfs, and orangefs? Currenly they have
readahead disabled and this patch would seem to enable it?
quoted hunk ↗ jump to hunk
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 8e8b00627bb2d8..2dac3be6127127 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -746,6 +746,8 @@ struct backing_dev_info *bdi_alloc(int node_id)
 		kfree(bdi);
 		return NULL;
 	}
+	bdi->ra_pages = VM_READAHEAD_PAGES;
+	bdi->io_pages = VM_READAHEAD_PAGES;
Won't this be more logical in bdi_init() than in bdi_alloc()?

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Thread (30 messages) 30 messages, 4 authors, last reply 2020-09-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help