Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API
From: Coly Li <hidden>
Date: 2017-08-08 06:50:27
Also in:
linux-bcache, lkml
From: Coly Li <hidden>
Date: 2017-08-08 06:50:27
Also in:
linux-bcache, lkml
On 2017/8/8 下午2:00, Byungchul Park wrote:
On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote:quoted
quoted
quoted
quoted
+ llist_for_each_entry_safe(cl, t, reverse, list) {Just wondering why not using llist_for_each_entry(), or you use the _safe version on purpose ?If I use llist_for_each_entry(), then it would change the original behavior. Is it ok?I feel llist_for_each_entry() keeps the original behavior, and variableAh.. I see. Then.. Can I change it into non-safe version? Is it still ok with non-safe one? I will change it at the next spin, if yes.quoted
't' can be removed. Anyway, either llist_for_each_entry() or llist_for_each_entry_safe() works correctly and well here. Any one you use is OK to me, thanks for your informative reply :-)I rather appriciate it.
Yes, please. And you have my Acked-by :-) -- Coly Li