Thread (8 messages) 8 messages, 3 authors, 2017-08-09

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

From: Byungchul Park <hidden>
Date: 2017-08-08 06:32:12
Also in: linux-bcache, lkml

On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote:
quoted
quoted
quoted
+	llist_for_each_entry_safe(cl, t, reverse, list) {
Just wondering why not using llist_for_each_entry(), or you use the
_safe version on purpose ?
If I use llist_for_each_entry(), then it would change the original
behavior. Is it ok?
I feel llist_for_each_entry() keeps the original behavior, and variable
Ah.. I see. Then.. Can I change it into non-safe version? Is it still ok
with non-safe one? I will change it at the next spin, if yes.
't' can be removed. Anyway, either llist_for_each_entry() or
llist_for_each_entry_safe() works correctly and well here. Any one you
use is OK to me, thanks for your informative reply :-)
I rather appriciate it.

Thank you,
Byungchul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help