Thread (4 messages) flat view 4 messages, 2 authors, 2017-04-03

Re: [PATCH] dm ioctl: Remove double parentheses

From: Joe Perches <joe@perches.com>
Date: 2017-04-01 02:07:42
Also in: dm-devel, lkml

On Fri, 2017-03-31 at 18:50 -0700, Matthias Kaehlcke wrote:
El Thu, Mar 16, 2017 at 09:48:30AM -0700 Matthias Kaehlcke ha dit:
quoted
The extra pair of parantheses is not needed and causes clang to generate
the following warning:

drivers/md/dm-ioctl.c:1776:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
        if ((cmd == DM_DEV_CREATE_CMD)) {
             ~~~~^~~~~~~~~~~~~~~~~~~~
drivers/md/dm-ioctl.c:1776:11: note: remove extraneous parentheses around the comparison to silence this warning
        if ((cmd == DM_DEV_CREATE_CMD)) {
            ~    ^                   ~
drivers/md/dm-ioctl.c:1776:11: note: use '=' to turn this equality comparison into an assignment
        if ((cmd == DM_DEV_CREATE_CMD)) {
There are dozens of these comparisons in the kernel.
Are you fixing them all or just this one?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help