Re: [PATCH] dm ioctl: Remove double parentheses
From: Matthias Kaehlcke <mka@chromium.org>
Date: 2017-04-01 01:50:23
Also in:
dm-devel, lkml
El Thu, Mar 16, 2017 at 09:48:30AM -0700 Matthias Kaehlcke ha dit:
quoted hunk ↗ jump to hunk
The extra pair of parantheses is not needed and causes clang to generate the following warning: drivers/md/dm-ioctl.c:1776:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if ((cmd == DM_DEV_CREATE_CMD)) { ~~~~^~~~~~~~~~~~~~~~~~~~ drivers/md/dm-ioctl.c:1776:11: note: remove extraneous parentheses around the comparison to silence this warning if ((cmd == DM_DEV_CREATE_CMD)) { ~ ^ ~ drivers/md/dm-ioctl.c:1776:11: note: use '=' to turn this equality comparison into an assignment if ((cmd == DM_DEV_CREATE_CMD)) { ^~ = Also remove another double parentheses that don't cause a warning. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- drivers/md/dm-ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index a5a9b17f0f7f..9360036bf6d3 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c@@ -1777,12 +1777,12 @@ static int validate_params(uint cmd, struct dm_ioctl *param) cmd == DM_LIST_VERSIONS_CMD) return 0; - if ((cmd == DM_DEV_CREATE_CMD)) { + if (cmd == DM_DEV_CREATE_CMD) { if (!*param->name) { DMWARN("name not supplied when creating device"); return -EINVAL; } - } else if ((*param->uuid && *param->name)) { + } else if (*param->uuid && *param->name) { DMWARN("only supply one of name or uuid, cmd(%u)", cmd); return -EINVAL; }
Ping? Any feedback on this patch? Cheers Matthias