Thread (80 messages) 80 messages, 6 authors, 2017-01-31

Re: split scsi passthrough fields out of struct request V2

From: Jens Axboe <axboe@fb.com>
Date: 2017-01-26 21:12:25
Also in: dm-devel, linux-block, linux-scsi

On 01/26/2017 02:01 PM, Bart Van Assche wrote:
On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote:
quoted
Your call path has blk_get_request() in it, I don't have
that in my tree. Is it passing in the right mask?
Hello Jens,

There is only one blk_get_request() call in drivers/md/dm-mpath.c
and it looks as follows:

 	clone = blk_get_request(bdev_get_queue(bdev),
			rq->cmd_flags | REQ_NOMERGE,
			GFP_ATOMIC);
Yeah, I found it in the dm patch. Looks fine to me, since
blk_mq_alloc_request() checks for __GFP_DIRECT_RECLAIM. Weird, it all
looks fine to me. Are you sure you tested with the patch? Either that,
or I'm smoking crack.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help