Re: [PATCH 14/18] scsi: remove __scsi_alloc_queue
From: "hch@lst.de" <hch@lst.de>
Date: 2017-01-28 08:23:52
Also in:
dm-devel, linux-block, linux-scsi
From: "hch@lst.de" <hch@lst.de>
Date: 2017-01-28 08:23:52
Also in:
dm-devel, linux-block, linux-scsi
On Fri, Jan 27, 2017 at 05:58:02PM +0000, Bart Van Assche wrote:
Since __scsi_init_queue() modifies data in the Scsi_Host structure, have you considered to add the declaration for this function to <scsi/scsi_host.h>? If you want to keep this declaration in <scsi/scsi_transport.h> please add a direct include of that header file to drivers/scsi/scsi_lib.c such that the declaration remains visible to the compiler if someone would minimize the number of #include directives in SCSI header files.
Feel free to send an incremental patch either way. In the long run I'd really like to kill off __scsi_init_queue and remove the transport BSG queue abuse of SCSI internals, though.