Re: [PATCH] raid5: panic() on dma_wait_for_async_tx() error
From: Alan Cox <hidden>
Date: 2012-11-08 11:10:27
Also in:
lkml
On Thu, 08 Nov 2012 11:06:29 +0100 Bartlomiej Zolnierkiewicz [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Bartlomiej Zolnierkiewicz <redacted> Subject: [PATCH] raid5: panic() on dma_wait_for_async_tx() error There is not much we can do on dma_wait_for_async_tx() error so just panic() for now. Cc: Neil Brown <redacted> Cc: Vinod Koul <redacted> Cc: Dan Williams <redacted> Cc: Tomasz Figa <redacted> Signed-off-by: Bartlomiej Zolnierkiewicz <redacted> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- drivers/md/raid5.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/md/raid5.c ===================================================================--- a/drivers/md/raid5.c 2012-11-07 16:25:19.480876012 +0100 +++ b/drivers/md/raid5.c 2012-11-07 16:27:46.244875992 +0100@@ -3223,7 +3223,9 @@ static void handle_stripe_expansion(stru /* done submitting copies, wait for them to complete */ if (tx) { async_tx_ack(tx); - dma_wait_for_async_tx(tx); + if (dma_wait_for_async_tx(tx) != DMA_SUCCESS) + panic("%s: DMA error waiting for transaction\n", + __func__);
Thats a really horrible place to panic. Alan