fix: memory leak in Create

Started by Czarnowska, Anna on Feb 17, 2011

Subsystems (1)

Maintainers (1)

DORMANTno replies

open the first message on its own page

Message details and related content
From 8307153207e20e218896adbb3ca9dfef63b0742c Mon Sep 17 00:00:00 2001
From: Anna Czarnowska <redacted>
Date: Thu, 17 Feb 2011 22:47:23 +0100
Subject: [PATCH 2/2] fix: memory leak in Create
Cc: <redacted>, Williams, Dan J <redacted>, Ciechanowski, Ed <redacted>

match_metadata_desc allocates memory for st
which is not needed after validate_geometry fails

Signed-off-by: Anna Czarnowska <redacted>
---
 Create.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Create.c b/Create.c
index a0669fe..ccda07b 100644
--- a/Create.c
+++ b/Create.c
@@ -309,8 +309,10 @@ int Create(struct supertype *st, char *mddev,
 				if (st && !st->ss->validate_geometry
 					    	(st, level, layout, raiddisks,
 						 chunk, size*2, dname, &freesize,
-						 verbose > 0))
+						 verbose > 0)) {
+					free(st);
 					st = NULL;
+				}
 			}
 
 			if (!st) {
-- 
1.7.1
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help