Thread (5 messages) 5 messages, 3 authors, 2010-01-29

Re: [mdadm PATCH] Move symbol definitions from source files to Makefile.

From: Neil Brown <hidden>
Date: 2010-01-29 21:54:38

On Fri, 29 Jan 2010 16:05:58 +0100
Artur Wojcik [off-list ref] wrote:
On Fri, 2010-01-29 at 09:45 +0000, Neil Brown wrote:
quoted
On Thu, 28 Jan 2010 16:47:45 +0100
Artur Wojcik [off-list ref] wrote:
quoted
This patch will move _GNU_SOURCE and _FILE_OFFSET_BITS=64 from
various source files to Makefile.
Why?
The reason is to clean up the code. The new files will appear soon and I
want this two definitions to be set globally instead of per source file.
Personally, I prefer them to be set just where they are needed.  You could
possibly convince me to put them in mdadm.h, but not in Makefile.
There's the plan to use GNU autotools to simply the build process, too.
That plan should be dropped immediately.  It won't happen.

NeilBrown
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help