Re: [mdadm PATCH] Move symbol definitions from source files to Makefile.
From: Andre Noll <hidden>
Date: 2010-01-28 17:02:59
Attachments
- signature.asc [application/pgp-signature] 189 bytes
From: Andre Noll <hidden>
Date: 2010-01-28 17:02:59
On 16:47, Artur Wojcik wrote:
This patch will move _GNU_SOURCE and _FILE_OFFSET_BITS=64 from various source files to Makefile.
That's fine by me, but let's see what Neil has to say about this. While cleaning up the #defines, we might want to get rid of a couple of unused ones at the same time. BLKPG_ADD_PARTITION, START_MD, REGISTER_DEV, MD_FEATURE_ALL, STDC, OF seem to be good candidates for removal. There are also quite some unused defines in super-ddf.c and super-intel.c, presumably because these files contain code that was copied from somewhere else. I'm not sure if it is worth to kill these as well though. Thanks Andre -- The only person who always got his work done by Friday was Robinson Crusoe