Re: [PATCH 06/13] async_tx: add support for asynchronous GF multiplication
From: H. Peter Anvin <hidden>
Date: 2009-03-20 23:41:34
Also in:
lkml
From: H. Peter Anvin <hidden>
Date: 2009-03-20 23:41:34
Also in:
lkml
Ilya Yanok wrote:
quoted
quoted
That doesn't explain what you expect the code to do. It still doesn't make sense to me.We defined async_pq() function as hardware can do GF multiplication of arbitrary elements and we want to take advantage of this fact. But by the design of ASYNC_TX API we have to provide synchronous version of that function too.
I don't think that makes sense since the algorithm doesn't use vector-vector multiplications and there is no need for them. As such, you're actively excluding support for hardware which only provides scalar-vector multiplication, even though that is all we need. In fact, vectorizing the constant doesn't make much sense. -hpa