Re: [PATCH] cpufreq: qoriq: Fix clk reference leak in get_bus_freq()
From: Zhongqiu Han <hidden>
Date: 2026-09-09 16:22:18
Also in:
lkml
Hello, On 9/9/2026 12:41 PM, blaze wrote:
clk_get() acquires a reference to the clock which must be released with
clk_put() when no longer needed. In get_bus_freq(), the clock reference
obtained by clk_get() is used only to read the frequency via
clk_get_rate(), but clk_put() is never called, causing a clock reference
count leak on every invocation.
Fix this by calling clk_put() before returning the frequency.
Fixes: 1b6f255990ae ("cpufreq: qoriq: Enhance the support of clock from DTS")I couldn't find this commit using either the commit ID or the subject. git show 1b6f255990ae fatal: ambiguous argument '1b6f255990ae': unknown revision or path not ...
quoted hunk ↗ jump to hunk
Signed-off-by: blaze <redacted> --- drivers/cpufreq/qoriq-cpufreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c index 0000000..1111111 100644
May I know why the blob hash is 0000000..1111111? Is this patch just generated by AI tools?
quoted hunk ↗ jump to hunk
--- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c@@ -62,7 +62,9 @@ static u32 get_bus_freq(void) __func__, PTR_ERR(pltclk)); return PTR_ERR(pltclk); } - return clk_get_rate(pltclk); + sysfreq = clk_get_rate(pltclk); + clk_put(pltclk); + return sysfreq; } static struct qoriq_cpu_data *qoriq_cpu_data; --2.43.0
-- Thx and BRs, Zhongqiu Han