Thread (2 messages) flat view 2 messages, 2 authors, 6d ago
COOLING6d

[PATCH] cpufreq: qoriq: Fix clk reference leak in get_bus_freq()

From: blaze <hidden>
Date: 2026-09-09 04:41:55
Also in: lkml
Subsystem: cpu frequency scaling framework, the rest · Maintainers: "Rafael J. Wysocki", Viresh Kumar, Linus Torvalds

clk_get() acquires a reference to the clock which must be released with
clk_put() when no longer needed. In get_bus_freq(), the clock reference
obtained by clk_get() is used only to read the frequency via
clk_get_rate(), but clk_put() is never called, causing a clock reference
count leak on every invocation.

Fix this by calling clk_put() before returning the frequency.

Fixes: 1b6f255990ae ("cpufreq: qoriq: Enhance the support of clock from DTS")
Signed-off-by: blaze <redacted>
---
 drivers/cpufreq/qoriq-cpufreq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c
index 0000000..1111111 100644
--- a/drivers/cpufreq/qoriq-cpufreq.c
+++ b/drivers/cpufreq/qoriq-cpufreq.c
@@ -62,7 +62,9 @@ static u32 get_bus_freq(void)
 			       __func__, PTR_ERR(pltclk));
 		return PTR_ERR(pltclk);
 	}

-	return clk_get_rate(pltclk);
+	sysfreq = clk_get_rate(pltclk);
+	clk_put(pltclk);
+	return sysfreq;
 }

 static struct qoriq_cpu_data *qoriq_cpu_data;
--
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help