Re: [PATCH] PM: Added functionality to the axp20x_battery driver
From: kernel test robot <hidden>
Date: 2021-11-08 05:22:14
Also in:
lkml, oe-kbuild-all
Hi Thomas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on lee-mfd/for-mfd-next] [also build test WARNING on sre-power-supply/for-next linux/master linus/master v5.15 next-20211108] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Marangoni/PM-Added-functionality-to-the-axp20x_battery-driver/20211025-225315 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next config: x86_64-randconfig-s021-20211027 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/246898bd0bf3718e9ef41526e6d2aa6a3fbb34f7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Thomas-Marangoni/PM-Added-functionality-to-the-axp20x_battery-driver/20211025-225315 git checkout 246898bd0bf3718e9ef41526e6d2aa6a3fbb34f7 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/power/supply/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> sparse warnings: (new ones prefixed by >>)
quoted
drivers/power/supply/axp20x_battery.c:105:11: sparse: sparse: symbol 'axp20x_ocv_values_uV' was not declared. Should it be static? drivers/power/supply/axp20x_battery.c:1004:1: sparse: sparse: symbol 'dev_attr_voltage_low_alert_level1' was not declared. Should it be static?
Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Attachments
- .config.gz [application/gzip] 28012 bytes