Thread (5 messages) 5 messages, 3 authors, 2021-11-08
STALE1720d

[RFC PATCH] PM: axp20x_ocv_values_uV[] can be static

From: kernel test robot <hidden>
Date: 2021-11-08 05:22:13
Also in: lkml, oe-kbuild-all
Subsystem: power supply class/subsystem and drivers, the rest · Maintainers: Sebastian Reichel, Linus Torvalds

drivers/power/supply/axp20x_battery.c:105:11: warning: symbol 'axp20x_ocv_values_uV' was not declared. Should it be static?
drivers/power/supply/axp20x_battery.c:1004:1: warning: symbol 'dev_attr_voltage_low_alert_level1' was not declared. Should it be static?

Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
---
 axp20x_battery.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c
index 5997c8192c73e..ec17841d51733 100644
--- a/drivers/power/supply/axp20x_battery.c
+++ b/drivers/power/supply/axp20x_battery.c
@@ -102,7 +102,7 @@ struct axp20x_batt_ps {
  * OCV curve has fixed values and percentage can be adjusted, this array represents
  * the fixed values in uV
  */
-const int axp20x_ocv_values_uV[AXP20X_OCV_MAX + 1] = {
+static const int axp20x_ocv_values_uV[AXP20X_OCV_MAX + 1] = {
 	3132800,
 	3273600,
 	3414400,
@@ -1001,7 +1001,7 @@ static ssize_t voltage_low_alert_level1_store(struct device *dev,
 	return count;
 }
 
-DEVICE_ATTR_RW(voltage_low_alert_level1);
+static DEVICE_ATTR_RW(voltage_low_alert_level1);
 
 static ssize_t voltage_low_alert_level2_show(struct device *dev,
 					     struct device_attribute *attr,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help