Re: [PATCH v5 2/2] cpupower: Fix to return negative value if no permisssion for read_msr

Started by Shuah Khan on Jul 26, 2021

open the first message on its own page

Message details and related content
On 7/23/21 12:26 AM, 徐福海 wrote:
From: xufuhai<redacted>  <mailto:<redacted>>

If the read_msr function is executed by a non-root user, the function returns
-1, which means that there is no permission to access//dev/cpu//%d/msr, but
cpufreq_has_boost_support should also return -1 immediately, and should not
follow the original logic to return 0, which will cause amd The cpupower tool
returns the boost active state as 0.

Reproduce procedure:
         cpupower frequency-info

Reported-by:   yangrui<redacted>  <mailto:<redacted>>
Signed-off-by: xufuhai<redacted>  <mailto:<redacted>>
Signed-off-by: chenguanqiao<redacted>  <mailto:<redacted>>
Signed-off-by: lishujin<redacted>  <mailto:<redacted>>
Please use your full names for the Signed-off-by - similar to the way you
would sign a legal document.

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help