Re: [PATCH v5 2/2] cpupower: Fix to return negative value if no permisssion for read_msr

On 7/23/21 12:26 AM, 徐福海 wrote:

From: xufuhai<redacted>  <mailto:xufuhai@kuaishou.com>

If the read_msr function is executed by a non-root user, the function returns
-1, which means that there is no permission to access//dev/cpu//%d/msr, but
cpufreq_has_boost_support should also return -1 immediately, and should not
follow the original logic to return 0, which will cause amd The cpupower tool
returns the boost active state as 0.

Reproduce procedure:
         cpupower frequency-info

Reported-by:   yangrui<redacted>  <mailto:yangrui@kuaishou.com>
Signed-off-by: xufuhai<redacted>  <mailto:xufuhai@kuaishou.com>
Signed-off-by: chenguanqiao<redacted>  <mailto:chenguanqiao@kuaishou.com>
Signed-off-by: lishujin<redacted>  <mailto:lishujin@kuaishou.com>

Please use your full names for the Signed-off-by - similar to the way you
would sign a legal document.

thanks,
-- Shuah