Re: [PATCH 1/2] PM: domains: call mutex_destroy when removing the genpd
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-06-15 13:51:58
Also in:
lkml
On Fri, Jun 11, 2021 at 01:15:39PM +0300, Dmitry Baryshkov wrote:
quoted hunk ↗ jump to hunk
It is a good practice to destroy mutexes with mutex_destroy, so call this function for releasing genpd->mlock. Signed-off-by: Dmitry Baryshkov <redacted> --- drivers/base/power/domain.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-)diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index b6a782c31613..74219d032910 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c@@ -1910,6 +1910,11 @@ static void genpd_lock_init(struct generic_pm_domain *genpd) } } +static void genpd_lock_destroy(struct generic_pm_domain *genpd) { + if (!(genpd->flags & GENPD_FLAG_IRQ_SAFE)) + mutex_destroy(&genpd->mlock); +}
Did you run this through checkpatch.pl??? And what does mutex_destroy() do that is required here? thanks, greg k-h