Re: [PATCH v3 2/3] sched/fair: Take thermal pressure into account while estimating energy
From: Lukasz Luba <lukasz.luba@arm.com>
Date: 2021-06-14 15:30:05
Also in:
lkml
Hi Vincent, Gentle ping. Could you have a look at this implementation, please? On 6/10/21 4:03 PM, Lukasz Luba wrote: [snip]
quoted hunk ↗ jump to hunk
@@ -6527,8 +6527,12 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd) struct cpumask *pd_mask = perf_domain_span(pd); unsigned long cpu_cap = arch_scale_cpu_capacity(cpumask_first(pd_mask)); unsigned long max_util = 0, sum_util = 0; + unsigned long _cpu_cap, thermal_pressure; int cpu; + thermal_pressure = arch_scale_thermal_pressure(cpumask_first(pd_mask)); + _cpu_cap = cpu_cap - thermal_pressure;
I've done the implementation according to your suggestion. That should provide the consistent usage. Regards, Lukasz