[PATCH v11 11/17] arm: tegra20/30: cpuidle: Remove unnecessary memory barrier
flat view
STALE2434d
REVIEWED: 6 (1M)
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-02-24 22:43:25
Also in:
linux-tegra, lkml
Subsystem:
arm port, the rest · Maintainers:
Russell King, Linus Torvalds
Status: Reviewed.
Revision v11 (8 revisions archived); 6 review trailers.
Revisions (8)
There is no good justification for smp_rmb() after returning from LP2 because there are no memory operations that require SMP synchronization. Thus remove the confusing barrier. Acked-by: Peter De Schrijver <redacted> Tested-by: Peter Geis <redacted> Tested-by: Jasper Korten <redacted> Tested-by: David Heidelberg <david@ixit.cz> Tested-by: Nicolas Chauvet <redacted> Acked-by: Daniel Lezcano <redacted> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- arch/arm/mach-tegra/cpuidle-tegra20.c | 2 -- arch/arm/mach-tegra/cpuidle-tegra30.c | 2 -- 2 files changed, 4 deletions(-)
diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c
index 8cdffdf7acd7..6db380515a6a 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra20.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra20.c@@ -197,8 +197,6 @@ static int tegra20_idle_lp2_coupled(struct cpuidle_device *dev, local_fiq_enable(); - smp_rmb(); - return entered_lp2 ? index : 0; } #endif
diff --git a/arch/arm/mach-tegra/cpuidle-tegra30.c b/arch/arm/mach-tegra/cpuidle-tegra30.c
index a4f0add46a27..80ae64bcdf50 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra30.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra30.c@@ -113,8 +113,6 @@ static int tegra30_idle_lp2(struct cpuidle_device *dev, local_fiq_enable(); - smp_rmb(); - return (entered_lp2) ? index : 0; } #endif
--
2.24.0