Thread (52 messages) 52 messages, 2 authors, 2020-02-24

[PATCH v9 11/17] arm: tegra20/30: cpuidle: Remove unnecessary memory barrier

flat view
STALE2438d SUPERSEDED: 4 (1M)

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-02-12 23:52:55
Also in: linux-tegra, lkml
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

Status: Superseded by v11 (posted 2020-02-24). [go to v11]

Revision v9 (8 revisions archived); 4 review trailers.

Revisions (8)
  1. v3
  2. v4 [diff against previous]
  3. v5 [diff against previous]
  4. v6 [diff against previous]
  5. v7 [diff against previous]
  6. v8 [diff against previous]
  7. v9 current [diff against previous] re-posted current
  8. v11 [diff against previous]
There is no good justification for smp_rmb() after returning from LP2
because there are no memory operations that require SMP synchronization.
Thus remove the confusing barrier.

Acked-by: Peter De Schrijver <redacted>
Tested-by: Peter Geis <redacted>
Tested-by: Jasper Korten <redacted>
Tested-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/mach-tegra/cpuidle-tegra20.c | 2 --
 arch/arm/mach-tegra/cpuidle-tegra30.c | 2 --
 2 files changed, 4 deletions(-)
diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c
index ccb8b0aa6c46..f8f14c0b79ff 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra20.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra20.c
@@ -194,8 +194,6 @@ static int tegra20_idle_lp2_coupled(struct cpuidle_device *dev,
 
 	local_fiq_enable();
 
-	smp_rmb();
-
 	return entered_lp2 ? index : 0;
 }
 #endif
diff --git a/arch/arm/mach-tegra/cpuidle-tegra30.c b/arch/arm/mach-tegra/cpuidle-tegra30.c
index a4f0add46a27..80ae64bcdf50 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra30.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra30.c
@@ -113,8 +113,6 @@ static int tegra30_idle_lp2(struct cpuidle_device *dev,
 
 	local_fiq_enable();
 
-	smp_rmb();
-
 	return (entered_lp2) ? index : 0;
 }
 #endif
-- 
2.24.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help