Thread (73 messages) 73 messages, 9 authors, 2017-06-19

Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq

From: Andy Shevchenko <hidden>
Date: 2017-06-03 17:33:03
Also in: linux-gpio, lkml, platform-driver-x86

On Sat, Jun 3, 2017 at 8:28 PM, Sathyanarayanan Kuppuswamy Natarajan
[off-list ref] wrote:
Hi,

On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko
[off-list ref] wrote:
quoted
On Thu, Jun 1, 2017 at 1:37 AM,
[off-list ref] wrote:
quoted
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

PMIC mfd driver only exports first level irq for thermal device.
But currently we are reading the irqs from the second level irq
chip, So this patch fixes this issue by adding support to use
first level PMIC thermal irq.
Shouldn't be this squashed to patch 2?
There is no compilation dependency between patch 2 and 3. But they are
functionally dependent.

Should we squash functionally dependent patches too ?
Let's assume we applied patches 1 and 2, does it mean the regression
to the existing behaviour?

(For example, device worked improperly in some cases -> stopped
working completely)

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help