Thread (73 messages) 73 messages, 9 authors, 2017-06-19

Re: [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq

From: Sathyanarayanan Kuppuswamy Natarajan <hidden>
Date: 2017-06-03 17:28:36
Also in: linux-gpio, lkml, platform-driver-x86

Hi,

On Sat, Jun 3, 2017 at 6:00 AM, Andy Shevchenko
[off-list ref] wrote:
On Thu, Jun 1, 2017 at 1:37 AM,
[off-list ref] wrote:
quoted
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

PMIC mfd driver only exports first level irq for thermal device.
But currently we are reading the irqs from the second level irq
chip, So this patch fixes this issue by adding support to use
first level PMIC thermal irq.
Shouldn't be this squashed to patch 2?
There is no compilation dependency between patch 2 and 3. But they are
functionally dependent.

Should we squash functionally dependent patches too ?
quoted
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Changes since v1:
 * None

Changes since v2:
 * Rebased on top of latest release.

Changes since v3:
 * Rebased on top of latest release.
diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c
index 0f19a39..ef6b322 100644
--- a/drivers/thermal/intel_bxt_pmic_thermal.c
+++ b/drivers/thermal/intel_bxt_pmic_thermal.c
@@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev)
        }

        regmap = pmic->regmap;
-       regmap_irq_chip = pmic->irq_chip_data_level2;
+       regmap_irq_chip = pmic->irq_chip_data;

        pmic_irq_count = 0;
        while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {
--
2.7.4


--
With Best Regards,
Andy Shevchenko


-- 
Sathya
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help