Thread (17 messages) 17 messages, 3 authors, 2017-02-04

Re: [PATCH v3 4/5] soc: samsung: pm_domains: Read domain name from the new label property

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2017-02-04 15:46:57
Also in: linux-devicetree, linux-samsung-soc

On Wed, Feb 01, 2017 at 10:25:54AM -0600, Rob Herring wrote:
On Mon, Jan 30, 2017 at 01:18:59PM +0100, Marek Szyprowski wrote:
quoted
Device tree nodes for each power domain should use generic "power-domain"
name, so using it as a domain name doesn't give much benefits. This patch
adds support for human readable names defined in 'label' property. Such
names are visible to userspace and makes debugging much easier. When no
'label' property is found, driver keeps using the name constructed from
full node name.
I'm not sure this is really a good use of label. label is intended for 
end user visible things like ports/connectors on a board. It's fine 
here, but I wouldn't want to see it used everywhere.
Thanks for comments. We want to use the label here for user visible
output - through dmesg or debugfs. Otherwise, we would have to stick
(always) to more descriptive node names, like "lcd-power-domain@xxxxx".

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help