On Mon, Aug 29, 2016 at 03:41:23PM +0200, Borislav Petkov wrote:

On Mon, Aug 29, 2016 at 09:15:00AM +0200, Pavel Machek wrote:

quoted

Sounds about as easy as hot unplugging arbitrary memory address. IOW
"not easy".

Regardless, forcibly panicking the system more is still the wrong
approach IMO.

Instead, I'd try to issue a big fat warning that BIOS corrupts E820 and
that the user should disable hibernation on that box and never ever
enable it again.

After that, the kernel should *disable* hibernation for the current boot
so any further hibernation runs don't even happen. Maybe even taint
itself.

I support this idea to disable hibernation when kernel detected e820 layout
was changed by BIOS. If system resume luckily then kernel should warn to user
and refuse to hibernate again. User must to know that's better to reboot
system when he saw the warning message after lucky resume.

Not just BIOS doesn't fix e820 layout. There have some machines doesn't provide
_S4_ function, so the hibernation fallbacks to "shutdown" mode because "platform"
mode unavailable. In this situation, user is just lucky to run the hibernation.
Kernel should warn to user and disable hibernation when detected e820 layout
changed.


Thanks a lot!
Joey Lee