Thread (9 messages) 9 messages, 2 authors, 2016-06-16

Re: lm-senser can't detect thermal on thermal_zone

From: Zhang Rui <rui.zhang@intel.com>
Date: 2016-06-14 13:24:25
Also in: linux-renesas-soc, lkml

On 二, 2016-06-14 at 07:03 +0000, Kuninori Morimoto wrote:
Hi Zhang
quoted
quoted
quoted
quoted
struct thermal_zone_device
*thermal_zone_device_register(xxxx)
{
	...
	if (!tz->tzp || !tz->tzp->no_hwmon) {
		result = thermal_add_hwmon_sysfs(tz);
		...
	}
	...
}

Does this mean "thermal_zone doesn't use lm-senser" ?
I'd prefer to say of_thermal registered thermal_zone doesn't use
lm-
sensor.
If you're really want to see hwmon interface, I think you should
use
thermal API (thermal_zone_device_register) directly.
Thank you for your feedback.
My driver is supporting both of_thermal and thermal API.
So, switching is not a big deal.

But can you teach me why of_thermal doesn't use lm-senser ??
I don't know if there is a solid reason that we can not expose the
hwmon interface. But just like the comment says, "/* No hwmon because
there might be hwmon drivers registering */", given that of_thermal
just parses THERMAL data of device tree, it is reasonable to me for
exposing thermal interfaces only.

thanks,
rui
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help