On 29 March 2016 at 08:32, Peter Chen [off-list ref] wrote:

quoted

On 28 March 2016 at 15:13, Peter Chen [off-list ref] wrote:

quoted

On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote:

quoted

On 25 March 2016 at 15:09, Peter Chen [off-list ref] wrote:

quoted

On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote:

quoted

Currently the Linux kernel does not provide any standard
integration of this feature that integrates the USB subsystem with
the system power regulation provided by PMICs meaning that either
vendors must add this in their kernels or USB gadget devices based
on Linux (such as mobile phones) may not behave as they should. Thus

provide a standard framework for doing this in kernel.

quoted

quoted

quoted

quoted

Now introduce one user with wm831x_power to support and test the
usb charger, which is pending testing. Moreover there may be other
potential users will use it in future.

I am afraid I still not find the user (udc driver) for this
framework, I would like to see how udc driver block the enumeration
until the charger detection has finished, or am I missing something?

It is not for udc driver but for power users who want to negotiate
with USB subsystem.

Then, where is the code the test user to decide what kinds of USB
charger (SDP, CDP, DCP) is connecting now?

Users can choose to implement multiple ways to get the charger type In
'usb_charger_detect_type()' function.

quoted

Then, how you test your code? When we introduce an API, at least, there is one
user for it.

At first I've tested the API on my board to make sure it can work
well, another hand we introduce one user 'wm831x_power' to support and
test the usb charger.

Yes, The user 'wm831x_power' did not implement any callbacks in
'usb_charger_detect_type()' function, but in
'usb_charger_detect_type()' function it just supplies different
callbacks to get the charger type with simple logic. Anyway we can try
to implement one callback to get the charger type and test the API.
Thanks.

Peter

-- 
Baolin.wang
Best Regards