Re: [PATCH 12/17] cpufreq: dt: Pass regulator name to the OPP core for V1 bindings
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-01-12 07:12:04
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-01-12 07:12:04
On 11-01-16, 17:53, Stephen Boyd wrote:
On 12/22, Viresh Kumar wrote:quoted
OPP core can handle the regulators by itself, and it allocates the regulator based on device's name. But for older V1 bindings, many DT files have used names like 'cpu-supply' instead of 'cpu0-supply'. The cpufreq-dt driver needs to tell the right name of the regulator in this case to the OPP core. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>This whole patch is confusing to me because old style was to be cpu0-supply, and new style is cpu-supply.
Long back we used to have cpu0-supply, then while I converted cpufreq-dt to support multiple clusters, you asked me to name it to cpu-supply, which I did. Now, looking at the implementation into the generic OPP layer, it looks like <device>-name is a far better and reasonable choice. And so I am moving back to cpu0-supply, will udpate binding doc as well. -- viresh