Re: [RFC V2 1/2] irq: Add a framework to measure interrupt timings

On 01/20/2016 08:28 PM, Peter Zijlstra wrote:

On Wed, Jan 20, 2016 at 05:00:32PM +0100, Daniel Lezcano wrote:

quoted

+++ b/kernel/irq/handle.c

@@ -165,6 +165,7 @@ irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
  			/* Fall through to add to randomness */
  		case IRQ_HANDLED:
  			flags |= action->flags;
+			handle_irqtiming(irq, action->dev_id);
  			break;

This also looks completely busted for shared interrupts.

Hi Peter,

As explained in an answer to Thomas, in case of shared interrupts, it is 
up to the prediction code to handle a tuple (irq, dev_id). The handler 
itself is at the right place IMO.

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog