On Mon, 2015-10-19 at 18:35 +0100, Sudeep Holla wrote:

Hi Ben,

On 23/09/15 05:06, Scott Wood wrote:

quoted

On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote:

quoted

mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets 
IRQF_NO_SUSPEND
flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak
is not implemented. Also there's no need to set the IRQF_NO_SUSPEND flag
as it doesn't guarantee wakeup for that interrupt.

This patch removes the redundant mpic_irq_set_wake and sets the
IRQCHIP_SKIP_SET_WAKE for only FSL MPIC.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Scott Wood <redacted>
Cc: Hongtao Jia <redacted>
Cc: Marc Zyngier <redacted>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Sudeep Holla <redacted>
---
  arch/powerpc/sysdev/mpic.c | 23 ++++-------------------
  1 file changed, 4 insertions(+), 19 deletions(-)

Acked-by: Scott Wood <redacted>

Can you pick this up via your tree ?

OK.

-Scott