Hi Greg,

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: Wednesday, January 09, 2013 10:30 PM
To: R, Durgadoss
Cc: Zhang, Rui; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org;
eduardo.valentin@ti.com; hongbo.zhang@linaro.org; wni@nvidia.com
Subject: Re: [PATCH 7/9] Thermal: Make PER_ZONE values configurable

On Wed, Jan 09, 2013 at 09:12:29AM +0000, R, Durgadoss wrote:

quoted

Hi Greg,

quoted

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: Tuesday, January 08, 2013 12:54 AM
To: R, Durgadoss
Cc: Zhang, Rui; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org;
eduardo.valentin@ti.com; hongbo.zhang@linaro.org; wni@nvidia.com
Subject: Re: [PATCH 7/9] Thermal: Make PER_ZONE values configurable

On Mon, Jan 07, 2013 at 12:43:24PM +0530, Durgadoss R wrote:

quoted

This patch makes MAX_SENSORS_PER_ZONE and
MAX_CDEVS_PER_ZONE values configurable. The
default value is 1, and range is 1-12.

Why would we ever want to change this?  Why make this configurable at
all, how is a distro supposed to set this value?

Shouldn't it be specified from the driver itself?

These are platform level parameters, that can differ for various platforms.
(Mostly due to board design and thermistor layouts). Stand-alone thermal
sensor drivers are not (need not be) aware of these values.

Ok, and how does anyone know how to set them properly?

quoted

That's why these values are made configurable.

Pushing work onto other people, without telling them what they need to
do, isn't nice.  Please, either make it auto-configurable, or don't make
it configurable at all.  As it is, this is useless for a distro, or any
"normal" user, right?

These values are for OEM's to configure according to their platform design.
So, not making them configurable won't be good IMHO.

But, as you said, for normal users, it does not matter; so they can
leave it as it is, which will set it to the default value (i.e 1).

Thanks,
Durga