Thread (5 messages) 5 messages, 3 authors, 2012-10-24

drivers/cpufreq/cpufreq_governor.c:46:53: sparse: incorrect type in argument 2 (different modifiers)

From: Fengguang Wu <hidden>
Date: 2012-10-23 05:01:53

Hi viresh,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
head:   13f5e2d9a915373dd1573d8fe0214738bc69004f
commit: 83a73f712f2275033b2dc7f5c664988a1823ebc7 cpufreq: Move common part from governors to separate file, v2
date:   5 hours ago

+ drivers/cpufreq/cpufreq_governor.c:46:53: sparse: incorrect type in argument 2 (different modifiers)
drivers/cpufreq/cpufreq_governor.c:46:53:    expected unsigned long long [usertype] *wall
drivers/cpufreq/cpufreq_governor.c:46:53:    got unsigned long long [nocast] [usertype] *wall
+ drivers/cpufreq/cpufreq_governor.c:46:53: sparse: implicit cast from nocast type
drivers/cpufreq/cpufreq_governor.c:48:58: sparse: incorrect type in argument 2 (different modifiers)
drivers/cpufreq/cpufreq_governor.c:48:58:    expected unsigned long long [usertype] *last_update_time
drivers/cpufreq/cpufreq_governor.c:48:58:    got unsigned long long [nocast] [usertype] *wall
drivers/cpufreq/cpufreq_governor.c:48:58: sparse: implicit cast from nocast type

vim +46 drivers/cpufreq/cpufreq_governor.c

83a73f71 viresh kumar 2012-10-23  30  	busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_SOFTIRQ];
83a73f71 viresh kumar 2012-10-23  31  	busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_STEAL];
83a73f71 viresh kumar 2012-10-23  32  	busy_time += kcpustat_cpu(cpu).cpustat[CPUTIME_NICE];
83a73f71 viresh kumar 2012-10-23  33  
83a73f71 viresh kumar 2012-10-23  34  	idle_time = cur_wall_time - busy_time;
83a73f71 viresh kumar 2012-10-23  35  	if (wall)
83a73f71 viresh kumar 2012-10-23  36  		*wall = jiffies_to_usecs(cur_wall_time);
83a73f71 viresh kumar 2012-10-23  37  
83a73f71 viresh kumar 2012-10-23  38  	return jiffies_to_usecs(idle_time);
83a73f71 viresh kumar 2012-10-23  39  }
83a73f71 viresh kumar 2012-10-23  40  
83a73f71 viresh kumar 2012-10-23  41  cputime64_t get_cpu_idle_time(unsigned int cpu, cputime64_t *wall)
83a73f71 viresh kumar 2012-10-23  42  {
83a73f71 viresh kumar 2012-10-23  43  	u64 idle_time = get_cpu_idle_time_us(cpu, NULL);
83a73f71 viresh kumar 2012-10-23  44  
83a73f71 viresh kumar 2012-10-23  45  	if (idle_time == -1ULL)
83a73f71 viresh kumar 2012-10-23 @46  		return get_cpu_idle_time_jiffy(cpu, wall);
83a73f71 viresh kumar 2012-10-23  47  	else
83a73f71 viresh kumar 2012-10-23  48  		idle_time += get_cpu_iowait_time_us(cpu, wall);
83a73f71 viresh kumar 2012-10-23  49  
83a73f71 viresh kumar 2012-10-23  50  	return idle_time;
83a73f71 viresh kumar 2012-10-23  51  }
83a73f71 viresh kumar 2012-10-23  52  EXPORT_SYMBOL_GPL(get_cpu_idle_time);

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help