On Tue, Feb 14, 2012 at 7:37 PM, David Miller [off-list ref] wrote:

From: Sameer Nanda <redacted>
Date: Tue, 14 Feb 2012 17:00:04 -0800

quoted

On Tue, Feb 14, 2012 at 4:13 PM, Francois Romieu [off-list ref] wrote:

quoted

Sameer Nanda [off-list ref] :

quoted

Set the WOL config registers to only enable WOL from magic packet by
default. Without this change in place, the WOL config register
settings on warm reboot come up in an inconsistent state since these
registers don't get reset on a warm reboot.

I am not completely convinced, especially as the change of behavior
could be noticed.

Agreed that this change could be noticed.  Maybe a module parameter
might be a better way to handle this?

Please no random module parameters, something ethtool based is
what you should shoot for.

With the existing code, WOL from PHY, unicast, multicast and broadcast
packets may get accidentally enabled.  The probability of seeing such
packets/events in the wild is quite high and this can cause unintended
wakes from S3 or reboots.

The probability of seeing matching MagicPackets in the wild is
vanishingly small.  Therefore, setting MagicPacket as the only default
WOL mechanism seems like the safer option.

Since ethtool already supports setting of WOL options from userland, I
guess we don't need a new module parameter as the user can set WOL
options according to his own desires.

-- 
Sameer