Thread (7 messages) 7 messages, 3 authors, 2012-02-16

Re: [PATCH 1/2] r8169: Enable WOL from Magic Packet by default

From: David Miller <davem@davemloft.net>
Date: 2012-02-15 03:37:46
Also in: netdev

From: Sameer Nanda <redacted>
Date: Tue, 14 Feb 2012 17:00:04 -0800
On Tue, Feb 14, 2012 at 4:13 PM, Francois Romieu [off-list ref] wrote:
quoted
Sameer Nanda [off-list ref] :
quoted
Set the WOL config registers to only enable WOL from magic packet by
default. Without this change in place, the WOL config register
settings on warm reboot come up in an inconsistent state since these
registers don't get reset on a warm reboot.
I am not completely convinced, especially as the change of behavior
could be noticed.
Agreed that this change could be noticed.  Maybe a module parameter
might be a better way to handle this?
Please no random module parameters, something ethtool based is
what you should shoot for.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help