Re: OpPoint summary
From: David Singleton <hidden>
Date: 2006-09-14 17:03:06
Also in:
lkml
Care to resend your patches in the proper format, through email so that we can see them, and possibly get some testing in -mm if they look sane?
Greg, here's the patch that leverages the cpufreq notifier lists for driver PRE and POST change functions. I'm also rebasing to 2.6.18-rc7 and making changes Pavel suggested about just having suspend states in /sys/power/state and moving the operating point control file down under /sys/power/operating_states directory. Signed-Off-by: David Singleton <redacted> drivers/cpufreq/cpufreq.c | 36 ++++++++++++++++++++++++++++++++++++ include/linux/cpufreq.h | 2 ++ 2 files changed, 38 insertions(+) Index: linux-2.6.17/drivers/cpufreq/cpufreq.c ===================================================================
--- linux-2.6.17.orig/drivers/cpufreq/cpufreq.c
+++ linux-2.6.17/drivers/cpufreq/cpufreq.c@@ -226,6 +226,35 @@ static void adjust_jiffies(unsigned long static inline void adjust_jiffies(unsigned long val, struct
cpufreq_freqs *ci) { return; }
#endif
+int cpufreq_prepare_transition(struct oppoint *cur, struct oppoint *new)
+{
+ struct cpufreq_freqs freqs;
+
+ freqs.old = cur->frequency;
+ freqs.new = new->frequency;
+ freqs.cpu = 0;
+ freqs.flags = new->flags;
+ blocking_notifier_call_chain(&cpufreq_transition_notifier_list,
+ CPUFREQ_PRECHANGE, &freqs);
+ adjust_jiffies(CPUFREQ_PRECHANGE, &freqs);
+ return 0;
+}
+EXPORT_SYMBOL(cpufreq_prepare_transition);
+
+int cpufreq_finish_transition(struct oppoint *cur, struct oppoint *new)
+{
+ struct cpufreq_freqs freqs;
+
+ freqs.old = cur->frequency;
+ freqs.new = new->frequency;
+ freqs.cpu = 0;
+ freqs.flags = new->flags;
+ adjust_jiffies(CPUFREQ_POSTCHANGE, &freqs);
+ blocking_notifier_call_chain(&cpufreq_transition_notifier_list,
+ CPUFREQ_POSTCHANGE, &freqs);
+ return 0;
+}
+EXPORT_SYMBOL(cpufreq_finish_transition);
/**
* cpufreq_notify_transition - call notifier chain and adjust_jiffies@@ -920,6 +949,12 @@ static void cpufreq_out_of_sync(unsigned } +#ifdef CONFIG_PM +unsigned int cpufreq_quick_get(unsigned int cpu) +{ + return (current_state->frequency); +} +#else /** * cpufreq_quick_get - get the CPU frequency (in kHz) frpm policy->cur * @cpu: CPU number
@@ -941,6 +976,7 @@ unsigned int cpufreq_quick_get(unsigned return (ret); } +#endif EXPORT_SYMBOL(cpufreq_quick_get);
Index: linux-2.6.17/include/linux/cpufreq.h ===================================================================
--- linux-2.6.17.orig/include/linux/cpufreq.h
+++ linux-2.6.17/include/linux/cpufreq.h@@ -268,6 +268,8 @@ static inline unsigned int cpufreq_quick return 0; } #endif +int cpufreq_prepare_transition(struct oppoint *cur, struct oppoint *new); +int cpufreq_finish_transition(struct oppoint *cur, struct oppoint *new); /*********************************************************************
thanks, greg k-h