Thread (18 messages) 18 messages, 5 authors, 2021-08-06

Re: [RFC PATCH 6/6] perf cs-etm: Add warnings for missing DSOs

From: James Clark <hidden>
Date: 2021-08-05 12:59:55
Also in: linux-arm-kernel, lkml


On 03/08/2021 15:01, Leo Yan wrote:
quoted
one can also use debuginfod-client, which, as time passes, probably will
be the main way of finding DSOs now that we have build-ids in
PERF_RECORD_MMAP2 and debuginfod servers such as:

export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/
If so, maybe should use more general description for missing DSO.
quoted
https://fedoraproject.org/wiki/Debuginfod
 
quoted
With this improvement, the patch looks good to me:

Reviewed-by: Leo Yan <redacted>
Does this apply to the other 5 patches in this series?
I finished to reivew patches 01, 04, 05, 06/06, so my review tag can
apply on these patches.  Current patch 06/06 needs James to improve for
the comments.
Thanks for the reviews, I've submitted v2.

I also had a play around with debuginfod, it looks promising.
Especially if it's integrated with perf report, which I assume is the plan?

Thanks
James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help