On Tue, Aug 03, 2021 at 01:34:36PM +0100, James Clark wrote:

On 31/07/2021 07:37, Leo Yan wrote:

quoted

quoted

quoted

diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c
index 85168d87b2d7..65a863bdf5cc 100644
--- a/tools/perf/arch/arm/util/cs-etm.c
+++ b/tools/perf/arch/arm/util/cs-etm.c

@@ -53,6 +53,7 @@ static const char *metadata_etmv4_ro[CS_ETMV4_PRIV_MAX] = {
        [CS_ETMV4_TRCIDR2]              = "trcidr/trcidr2",
        [CS_ETMV4_TRCIDR8]              = "trcidr/trcidr8",
        [CS_ETMV4_TRCAUTHSTATUS]        = "mgmt/trcauthstatus",
+       [CS_ETE_TRCDEVARCH]             = "mgmt/trcdevarch"

ETMv4 supports TRCDEVARCH, so I think it's good to use the naming
"CS_ETMV4_TRCDEVARCH"?

Based on the other discussions do you still think I should do this?

No, don't need to add TRCDEVARCH for ETMv4 anymore.

As part of the new magic number I moved it into a new enum so it
might be clearer now?

Regard ETMv4 and ETE use the different decoder types from OpenCSD, you
could add a new magic number and new enum for ETE.  It would be easier
for later extension for ETMv4 and ETE separately if decoder requires
to pass more config info.

Thanks,
Leo